Re: [libvirt] [PATCH RFC 38/40] tests: qemustatusxml2xml: Add test for 'pull' type backup job
On 10/18/19 11:11 AM, Peter Krempa wrote:
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
.../qemustatusxml2xmldata/backup-pull-in.xml | 607 ++++++++++++++++++
.../qemustatusxml2xmldata/backup-pull-out.xml | 1 +
tests/qemuxml2xmltest.c | 2 +
3 files changed, 610 insertions(+)
create mode 100644 tests/qemustatusxml2xmldata/backup-pull-in.xml
create mode 120000 tests/qemustatusxml2xmldata/backup-pull-out.xml
+ <flag name='incremental-backup'/>
+ </qemuCaps>
+ <blockjobs active='yes'>
+ <blockjob name='backup-vda-libvirt-3-format' type='backup'
state='running'>
+ <disk dst='vda'/>
+ <bitmap name='bitmapname'/>
+ <backup id='1'/>
+ <store type='file' format='qcow2'>
+ <source file='/path/to/file' index='1337'>
+ <privateData>
+ <nodenames>
+ <nodename type='storage'
name='libvirt-1337-storage'/>
+ <nodename type='format'
name='libvirt-1337-format'/>
+ </nodenames>
+ </privateData>
+ </source>
+ </store>
+ </blockjob>
+ </blockjobs>
+ <backups nextid='2'>
+ <domainbackup mode='pull' id='1'>
+ <incremental>12345</incremental>
+ <server transport='tcp' name='localhost'
port='10809'/>
+ <disks>
+ <disk name='vda' backup='yes' state='running'
type='file'>
+ <scratch file='/path/to/file/'/>
+ </disk>
+ </disks>
+ </domainbackup>
+ </backups>
Looks good.
diff --git a/tests/qemustatusxml2xmldata/backup-pull-out.xml
b/tests/qemustatusxml2xmldata/backup-pull-out.xml
new file mode 120000
index 0000000000..b706ee2924
--- /dev/null
+++ b/tests/qemustatusxml2xmldata/backup-pull-out.xml
@@ -0,0 +1 @@
+backup-pull-in.xml
\ No newline at end of file
Do we have to create .out symlinks when the .in is otherwise useful
as-is? But you've done more with testsuite cleanups than me, so I trust
you on this one.
Reviewed-by: Eric Blake <eblake(a)redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org