Re: [libvirt] [PATCH v3 0/3] Improve release notes process
On 01/10/2017 10:25 AM, Andrea Bolognani wrote:
Dan raised some concerns, but it doesn't look like they're
critical enough for him to NACK the series; moreover, it's
all stuff that we can easily address later on, so I'd like
to move forward with this before the freeze.
Details of changes can be found in the single patches.
Andrea Bolognani (3):
NEWS: Improve building pipeline
NEWS: Reformat at generation time
docs: Document the release notes process for contributors
.gitignore | 1 +
HACKING | 7 ++
Makefile.am | 26 ++++--
docs/Makefile.am | 28 +++++-
docs/hacking.html.in | 10 ++
docs/news-ascii.xsl | 68 ++++++++++++++
docs/news-html.xsl | 96 +++++++++++++++++++
docs/news.html.in | 164 --------------------------------
docs/news.xml | 252 ++++++++++++++++++++++++++++++++++++++++++++++++++
docs/news.xsl | 50 ----------
docs/reformat-news.py | 104 +++++++++++++++++++++
11 files changed, 583 insertions(+), 223 deletions(-)
create mode 100644 docs/news-ascii.xsl
create mode 100644 docs/news-html.xsl
delete mode 100644 docs/news.html.in
create mode 100644 docs/news.xml
delete mode 100644 docs/news.xsl
create mode 100755 docs/reformat-news.py
I'm "mostly" fine with the changes - would like resolution sooner than
later since I have a couple of things to add to news, but I didn't want
to cause you extra merge cycles ;-)
The *one* thing I'm really having a hard time with is not ending
sentences with a period for <description>'s. Especially when there's
two or more sentences within a <description> where the first one ends
with a period, but the second one doesn't
Not ending the previous paragraph without a period was really difficult
for my fingers. I wouldn't hold up a ACK though for having or not
having a period.
John