Re: [libvirt] [PATCH v3 02/14] vbox: Rewrite vboxNetworkOpen
On 02.10.2014 05:30, Taowei wrote:
---
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/vbox/vbox_network.c | 58 +++++++++++++++++++++++++++++++++++++++++
src/vbox/vbox_tmpl.c | 24 -----------------
src/vbox/vbox_uniformed_api.h | 3 +++
5 files changed, 63 insertions(+), 24 deletions(-)
create mode 100644 src/vbox/vbox_network.c
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 020a9ac..9e00f73 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -220,6 +220,7 @@ src/vbox/vbox_MSCOMGlue.c
src/vbox/vbox_XPCOMCGlue.c
src/vbox/vbox_driver.c
src/vbox/vbox_common.c
+src/vbox/vbox_network.c
Not yet, there are no translations in vbox_network.c so far.
src/vbox/vbox_snapshot_conf.c
src/vbox/vbox_tmpl.c
src/vmware/vmware_conf.c
diff --git a/src/Makefile.am b/src/Makefile.am
index dcd2ae2..34eb9f8 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -678,6 +678,7 @@ VBOX_DRIVER_SOURCES = \
vbox/vbox_V4_3.c vbox/vbox_CAPI_v4_3.h \
vbox/vbox_V4_3_4.c vbox/vbox_CAPI_v4_3_4.h \
vbox/vbox_common.c vbox/vbox_common.h \
+ vbox/vbox_network.c \
vbox/vbox_uniformed_api.h \
vbox/vbox_get_driver.h
diff --git a/src/vbox/vbox_network.c b/src/vbox/vbox_network.c
new file mode 100644
index 0000000..2e09b4b
--- /dev/null
+++ b/src/vbox/vbox_network.c
@@ -0,0 +1,58 @@
+/*
+ * Copyright 2014, Taowei Luo (uaedante(a)gmail.com)
I guess we can't just drop the other copyright owners. I mean
vboxNetworkOpen() is not something you invented, you've just copying
that over to a different file. So I'll include the original copyright
notices over here too. I should have noticed this in previous patches
too, sorry.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>;.
+ */
Michal