Re: [libvirt] [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

On Tue, May 06, 2014 at 10:01:11PM +0200, Igor Mammedov wrote: > On Tue, 6 May 2014 11:42:56 -0300 > Eduardo Habkost <ehabkost(a)redhat.com&gt; wrote: >> On Tue, May 06, 2014 at 09:22:38AM +0200, Igor Mammedov wrote: >>> On Fri, 2 May 2014 11:43:05 -0300 >>> Eduardo Habkost <ehabkost(a)redhat.com&gt; wrote: >>>> On Fri, May 02, 2014 at 03:45:03PM +0200, Igor Mammedov wrote: >>>>> On Wed, 30 Apr 2014 17:29:28 -0300 >>>>> Eduardo Habkost <ehabkost(a)redhat.com&gt; wrote: >>>>>> This series allows management code to use object-add on X86CPU subclasses, so it >>>>> Is there any reason why "device-add" couldn't be used? >>>> It needs to work with "-machine none", device_add requires a bus to >>>> exist, and there is no icc-bus on machine_none. >>> The thing is that CPUID is a function of machine so using >>> "-machine none" will provide only approximately accurate data. >>> I'm not sure that retrieved possibly not accurate data are useful >>> for libvirt. >> "-cpu host" doesn't depend on machine, and is the most important thing >> right now (because libvirt's checks for host QEMU/kernel/CPU >> capabilities is completely broken). > true, but device-add/-cpu host could be used right now to get the > same CPUID data wile using any machine type or default one without > any of this patches. device_add can't be used with "-machine none".