Re: [libvirt] [PATCH V4 1/3] Introduce support for parsing/formatting Xen xl config format

On 01/13/2015 04:47 PM, Jim Fehlig wrote: >>> +++ b/src/Makefile.am >>> @@ -1005,6 +1005,10 @@ XENCONFIG_SOURCES = \ >>> xenconfig/xen_common.c xenconfig/xen_common.h \ >>> xenconfig/xen_sxpr.c xenconfig/xen_sxpr.h \ >>> xenconfig/xen_xm.c xenconfig/xen_xm.h >>> +if WITH_LIBXL >>> +XENCONFIG_SOURCES += \ >>> + xenconfig/xen_xl.c xenconfig/xen_xl.h >>> +endif WITH_LIBXL >>> >>> >> Missing an EXTRA_DIST listing to ensure these two files are part of a >> tarball even when configure does not build libxl sources (that is, make >> sure 'make distcheck' will not fail if configured on a machine without >> libxl support). >> >> > Several of the tests fail on the old distro I'm testing on, which causes > 'make distcheck' to fail. But I assumed I could simulate it on a newer > distro with 'configure --without-libxl', yet 'make distcheck' succeeds > and the files are included in the tarball. Are you seeing a failure on > RHEL5? > I haven't yet tested a 'make distcheck' on that particular VM of mine; I'll fire one off and see what happens. It might be simpler to just to check that if 'make dist' is run when configured --without-libxl, then it still includes both files in the tarball.