Re: [libvirt] [PATCH] virsh: Forbid usage of --memspec and --disk-only together
On 01/25/2013 03:56 AM, Peter Krempa wrote:
virsh snapshot-create-as with --memspec and --disk only fails at the
qemu driver. Forbid the creation at virsh too and document it.
---
tools/virsh-snapshot.c | 6 ++++++
tools/virsh.pod | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
For testing purposes, allowing invalid combinations all the way down to
qemu_driver.c is useful to make sure the driver behaves right. But I
suppose it is okay to make this change in virsh, for a friendlier error
message. It may be worth listing the before-and-after error messages in
the commit message, to show how it helps.
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)