Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote:
At Fri, 21 Feb 2014 11:01:47 +0000,
Daniel P. Berrange wrote:
>
> ACK, if you also add the virEventUpdateTimeout method
OK, but why should I add it? It's useless (for the user) and unused by
the wrapping code. I want to keep the JNA library definition clean --
e.g. in a later patch I remove all the *UUIDString functions.
What makes you say it is useless ? The UpdateTimeout method lets you
alter the timeout value for an existing timer, without having to go
through Remove+Add of it. This might seem like a subtle distinction,
but the difference is that the UpdateTimeout is guaranteed not to
fail, where as Remove+Add may fail.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|