Re: [libvirt] [PATCH] qemucaps2xmltest: fix test to successfully run without kvm support
Hi,
On Wed, Mar 25, 2015 at 12:29:41PM +0100, Pavel Hrdina wrote:
On Wed, Mar 25, 2015 at 12:12:20PM +0100, Ján Tomko wrote:
> On Wed, Mar 25, 2015 at 10:50:52AM +0100, Pavel Hrdina wrote:
> > Function virQEMUCapsInitGuestFromBinary detect kvm support by testing
> > whether /dev/kvm exists or whether we pass path to kvmbin. Provide the
> > path we are testing via kvmbin for testing purpose instead of detecting
> > presence of /dev/kvm to successfully run the tests on all hosts.
> >
> > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
> > ---
> > tests/qemucaps2xmltest.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> ACK
>
> Jan
Thanks, pushed now.
According to
Testbuild:
http://honk.sigxcpu.org:8001/job/libvirt-check/3300/consoleFull
SourceBuild
http://honk.sigxcpu.org:8001/job/libvirt-build/3730/
this broke on Debian Wheezy like:
TEST: qemucaps2xmltest
1) all_1.6.0-1 ...
Offset 280
Expect [ <domain type='kvm'>
<emulator>/usr/bin/qemu-system-i386</emulator>
</domain>
<]
Actual [<]
... FAILED
2) nodisksnapshot_1.6.0-1 ...
Offset 280
Expect [ <domain type='kvm'>
<emulator>/usr/bin/qemu-system-i386</emulator>
</domain>
<]
Actual [<]
... FAILED
FAIL: qemucaps2xmltest
I didn't get a chance to look into this in any detail yet. Any idea
what went wrong?
Cheers,
-- Guido