Re: [libvirt] [PATCH] Protect against NULL pointer flaws in monitor usage (v2)
On Mon, May 17, 2010 at 11:31:25AM -0600, Eric Blake wrote:
On 05/17/2010 11:13 AM, Daniel P. Berrange wrote:
> History has shown that there are frequent bugs in the QEMU driver
> code leading to the monitor being invoked with a NULL pointer.
> Although the QEMU driver code should always report an error in
> this case before invoking the monitor, as a safety net put in a
> generic check in the monitor code entry points.
>
> * src/qemu/qemu_monitor.c: Safety net to check for NULL monitor
> object
Any quick pointers on how this differs from v1?
It doesn't differ. I sent the wrong patch :-) I meant to re-send patch 1,
not patch 2
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|