Re: [libvirt] [PATCH v8 09/11] libvirt: add new public API to get launch security info

On 06/07/2018 11:46 AM, Erik Skultety wrote: > Better commit subject would be: > libvirt: Introduce virDomainGetLaunchSecurityInfo public API > > On Wed, Jun 06, 2018 at 12:50:15PM -0500, Brijesh Singh wrote: >> The API can be used outside the libvirt to get the launch security >> information. When SEV is enabled, the API can be used to get the >> measurement of the launch process. >> >> Signed-off-by: Brijesh Singh <brijesh.singh(a)amd.com&gt; >> --- >> include/libvirt/libvirt-domain.h | 17 ++++++++++++++ >> src/driver-hypervisor.h | 8 +++++++ >> src/libvirt-domain.c | 48 ++++++++++++++++++++++++++++++++++++++++ >> src/libvirt_public.syms | 1 + >> 4 files changed, 74 insertions(+) >> >> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h >> index da773b7..6a3d73f 100644 >> --- a/include/libvirt/libvirt-domain.h >> +++ b/include/libvirt/libvirt-domain.h >> @@ -4767,4 +4767,21 @@ int virDomainSetLifecycleAction(virDomainPtr domain, >> unsigned int action, >> unsigned int flags); >> >> +/** >> + * Launch Security API >> + */ >> + >> +/** >> + * VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT: >> + * >> + * Macro represents the launch measurement of the SEV guest, >> + * as VIR_TYPED_PARAM_STRING. >> + */ >> +#define VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT "sev-measurement" > > ^recurring, s/#define/# define/ otherwise fails the syntax-check... I did ran through syntax-check but don't remember getting complain. I will fix in next rev.

> > With that: > Reviewed-by: Erik Skultety <eskultet(a)redhat.com&gt; > -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list