Re: [libvirt] [PATCH v1 28/32] util: pidfile: use VIR_AUTOFREE instead of VIR_FREE for scalar types
On Sat, Jul 28, 2018 at 11:31:43PM +0530, Sukrit Bhatnagar wrote:
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: Sukrit Bhatnagar <skrtbhtngr(a)gmail.com>
---
...
@@ -219,11 +199,11 @@ int virPidFileReadPathIfAlive(const char *path,
{
int ret;
bool isLink;
- char *procPath = NULL;
- char *procLink = NULL;
+ VIR_AUTOFREE(char *) procPath = NULL;
+ VIR_AUTOFREE(char *) procLink = NULL;
+ VIR_AUTOFREE(char *) resolvedBinPath = NULL;
+ VIR_AUTOFREE(char *) resolvedProcLink = NULL;
I'll move ^this at the end of the section.
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>