Re: [libvirt] [PATCH 1/2] qemu: Improve validation for virtio input devices
On Fri, 2019-03-08 at 15:05 -0500, Cole Robinson wrote:
On 3/6/19 7:17 AM, Andrea Bolognani wrote:
> + DO_TEST_PARSE_ERROR("virtio-transitional-not-supported",
> + QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE,
> + QEMU_CAPS_DEVICE_PCI_BRIDGE,
> + QEMU_CAPS_DEVICE_IOH3420);
I'm thoroughly 'meh' to the idea of adding XML tests to exercise
validation failures like this, but only enough to make this comment
I respectfully disagree: having test coverage for the negative cases
is very useful to stop regressions from sneaking back in.
Anyway, I've fixed the typo you spotted and pushed the series.
Thanks for the review! :)
--
Andrea Bolognani / Red Hat / Virtualization