Re: [libvirt] [RFC PATCH 1/5] storage: encryption: Add deep copy function for storage encryption
On 06/12/14 23:19, Eric Blake wrote:
...
> ACK with problems fixed.
I'll hold of pushing this until the next revision when I'll figure out
whether the approach is reasonable.
Peter
On 06/12/2014 09:02 AM, Peter Krempa wrote:
> ---
> src/util/virstorageencryption.c | 39 +++++++++++++++++++++++++++++++++++++++
> src/util/virstorageencryption.h | 2 ++
> 2 files changed, 41 insertions(+)
I've definitely been wishing for this; as our struct gets more
complicated, piece-wise transfers into a temporary will not be robust,
while copying into a temporary can be.
Did you need to export the new symbol in libvirt_private.syms?
Currently it isn't needed as it's only used in the "src/util/" subdir.
Attachments:
- signature.asc (application/pgp-signature — 901 bytes)