Re: [libvirt] [RFC PATCH 2/2] vbox: Implement virDomainSendKey

On Thu, Mar 19, 2015 at 05:43:57PM -0400, Dawid Zamirski wrote: > Since the holdtime is not supported by VBOX SDK, it's being > simulated > by sleeping before sending the key-up codes. The key-up codes are > auto-generated based on XT codeset rules (adding of 0x80 to key- > down) > which results in the same behavior as for QEMU implementation. > --- > src/vbox/vbox_common.c | 107 > +++++++++++++++++++++++++++++++++++++++++++++++++ > src/vbox/vbox_common.h | 1 + > 2 files changed, 108 insertions(+) > Looks good to me, a few nits inline: Jan