Re: [PATCH v3 04/30] qapi/qom: Add ObjectOptions for cryptodev-*
On 3/8/21 10:54 AM, Kevin Wolf wrote:
This adds a QAPI schema for the properties of the cryptodev-*
objects.
These interfaces have some questionable aspects (cryptodev-backend is
really an abstract base class without function, and the queues option
only makes sense for cryptodev-vhost-user), but as the goal is to
represent the existing interface in QAPI, leave these things in place.
Signed-off-by: Kevin Wolf <kwolf(a)redhat.com>
Acked-by: Peter Krempa <pkrempa(a)redhat.com>
---
qapi/qom.json | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
@@ -239,6 +267,9 @@
'authz-listfile',
'authz-pam',
'authz-simple',
+ 'cryptodev-backend',
+ 'cryptodev-backend-builtin',
+ 'cryptodev-vhost-user',
Shouldn't the enum value be conditional...
'iothread'
] }
@@ -262,6 +293,10 @@
'authz-listfile': 'AuthZListFileProperties',
'authz-pam': 'AuthZPAMProperties',
'authz-simple': 'AuthZSimpleProperties',
+ 'cryptodev-backend': 'CryptodevBackendProperties',
+ 'cryptodev-backend-builtin': 'CryptodevBackendProperties',
+ 'cryptodev-vhost-user': { 'type':
'CryptodevVhostUserProperties',
+ 'if': 'defined(CONFIG_VIRTIO_CRYPTO)
&& defined(CONFIG_VHOST_CRYPTO)' },
...if the union branch is likewise?
'iothread':
'IothreadProperties'
} }
With that fixed,
Reviewed-by: Eric Blake <eblake(a)redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org