Re: [libvirt] [PATCH 1/2] event: fix doc typos, and doc more public methods

On 01/02/2014 03:56 PM, Eric Blake wrote: > On 01/02/2014 09:32 AM, Eric Blake wrote: >> While working on events, I found a number of minor issues; I'm >> hoisting these to the front rather than doing it piecemeal in >> the patches where I first noticed bad or missing documentation. >> >> * src/conf/object_event.c: Fix grammar, document all parameters >> of public functions; wrap some long lines. >> * src/conf/object_event.h: Likewise. >> * src/conf/network_event.c: Likewise. >> * src/conf/domain_event.c: Likewise (except for the large number >> of event creation functions). >> >> Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; >> --- >> src/conf/domain_event.c | 64 +++++++++++++++++++++++++-------------- >> src/conf/network_event.c | 26 +++++++++++----- >> src/conf/object_event.c | 78 +++++++++++++++++++++++++++++++++++++++++++----- >> src/conf/object_event.h | 7 +++-- >> 4 files changed, 134 insertions(+), 41 deletions(-) > > And squashing in this use of bool (hmm, once again pasting in causes > line wrapping :( ) > ACK series