Re: [libvirt PATCH] ci: move dco-check to a later stage
On Tue, Jul 28, 2020 at 11:39:10 +0200, Ján Tomko wrote:
Be less hostile to developers and run the build jobs even
if the dco-check failed. That way they can test their own
"private" branches without a sign-off.
Also specify empty `needs` for it, since it does not depend
on any of the jobs in the container phase and can be run
right away.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
https://gitlab.com/jano.tomko/libvirt/-/pipelines/171532004
I very much welcome this change, since the sign-off is a useful hint if
some patches are incomplete. You still might want to have them compile
tested with the ci though.
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>