Re: [libvirt] [PATCH] fix diagnostic when execute openvz commands

Evgeniy Sokolov <evg(a)openvz.org&gt; wrote:

> +void > +error (virConnectPtr conn, virErrorNumber code, const char *fmt, ...) Now that you've given it external scope, please use a different name. There are already at least two other "error" functions, including the static one in remote_internal.c, and the external one in glibc/gnulib.

> +void error (virConnectPtr conn, virErrorNumber code, const char *fmt, ...); Whatever its name, please do two more things: - add "ATTRIBUTE_FORMAT(printf, 3, 4)" before the semicolon, so that gcc -Wformat compares the format string with types of corresponding arguments. (this must be done with any varargs "..." printf/scanf-style function) - add the new name to the list in Makefile.cfg (msg_gen_function), and ensure that "make syntax-check" passes. (this must be done for any function that takes a diagnostic string as an argument)