Re: [libvirt] [PATCH] virsh-volume: Unify alignment of vol-list output columns
On 11/12/13 15:35, Daniel P. Berrange wrote:
On Tue, Nov 12, 2013 at 03:16:53PM +0100, Peter Krempa wrote:
> Add an extra space before the first column as we have when listing
> domains.
>
...
> ---
> tools/virsh-volume.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
ACK, this matches style used for 'virsh list'. Have you checked if any
other 'list' commands lack the leading space ?
I checked the rest of the listing commands: (domain) list, net-list and
snapshot-list have the space already and I've sent patches for
secret-list, iface-list, pool-list and nwfilter-list.
Pushed; Thanks for the review.
Peter
Attachments:
- signature.asc (application/pgp-signature — 901 bytes)