Re: [libvirt] [PATCH] test: fix screenshot API impl

On Tue, 2016-12-06 at 13:04 +0000, Daniel P. Berrange wrote: > On Tue, Dec 06, 2016 at 01:58:50PM +0100, Peter Krempa wrote: > > > > On Tue, Dec 06, 2016 at 12:49:21 +0000, Daniel Berrange wrote: > > > > > > When redoing the website we deleted the libvirtLogo.png file > > > not remembering that the test driver screenshot API impl > > > relied on it. > > > > > > Rather than having the test driver use the logo as a side > > > effect, give it its own dedicated image to use. This is > > > installed in /usr/share/libvirt/test-screenshot.png and > > > > Is it worth wasting 48k of disk space for a picture that almost nobody > > ever will see on every installation of libvirt? > > 48k is completely lost in the noise when you consider the minimal install > footprint of libvirt. libvirt-libs is 23 MB in size, not even counting > the dependancies it pulls in. How about a pngcrush'd 640x480 solid color? Not only it would be way smaller, but we would also remove any possible confusion about it being an actual screenshot of a running domain.