Re: [libvirt] [PATCH 2/2] qemu: generate -display none

This is preferrable to -nographic which (in addition to disabling graphics output) redirects the serial port to stdio and on OpenBIOS enables the firmware's serial console. Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com&gt; --- src/qemu/qemu_command.c | 7 ++++- src/qemu/qemu_parse_command.c | 4 +++ .../qemuargv2xml-nographics-vga-display.args | 23 +++++++++++++++ .../qemuargv2xml-nographics-vga-display.xml | 34 ++++++++++++++++++++++ tests/qemuargv2xmltest.c | 1 + .../qemuxml2argv-nographics-display.args | 22 ++++++++++++++ .../qemuxml2argv-nographics-display.xml | 25 ++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ tests/qemuxml2xmltest.c | 2 +- 9 files changed, 118 insertions(+), 2 deletions(-) create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-nographics-vga-display.args create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-nographics-vga-display.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-nographics-display.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-nographics-display.xml diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 3898ed7..68ee313 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9210,7 +9210,12 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, * these defaults ourselves... */ if (!def->ngraphics) { - virCommandAddArg(cmd, "-nographic"); + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISPLAY)) { + virCommandAddArg(cmd, "-display"); + virCommandAddArg(cmd, "none"); + } else { + virCommandAddArg(cmd, "-nographic"); + }