Re: [libvirt PATCH 261/351] meson: tools: generate virt-xml-validate script

On Thu, Jul 16, 2020 at 11:58:17 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > tools/Makefile.am | 7 +------ > tools/meson.build | 12 ++++++++++++ > 2 files changed, 13 insertions(+), 6 deletions(-) > [...] > diff --git a/tools/meson.build b/tools/meson.build > index d2d82903f1c..5e985cff593 100644 > --- a/tools/meson.build > +++ b/tools/meson.build > @@ -215,3 +215,15 @@ executable( > install_dir: bindir, > install_rpath: libdir, > ) > + > +tools_conf = configuration_data() > +tools_conf.set('VERSION', meson.project_version()) > +tools_conf.set('schemadir', pkgdatadir / 'schemas') > + > +configure_file( > + input: 'virt-xml-validate.in', > + output: 'virt-xml-validate', > + configuration: tools_conf, > + install: true, > + install_dir: bindir, > +) Does this preserve the executable bit? I think I've reported some files having wrong exec permissions and it might have been this.