Re: [libvirt] [PATCH] qemu: Avoid assigning unavailable migration ports

On 10/15/2013 02:42 PM, Jiri Denemark wrote: > From: WangYufei <james.wangyufei(a)huawei.com&gt; > > https://bugzilla.redhat.com/show_bug.cgi?id=1019053 > > When we migrate vms concurrently, there's a chance that libvirtd on > destination assigns the same port for different migrations, which will > lead to migration failure during prepare phase on destination. So we use > virPortAllocator here to solve the problem. > > Signed-off-by: WangYufei <james.wangyufei(a)huawei.com&gt; > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; > --- > src/qemu/qemu_command.h | 3 +++ > src/qemu/qemu_conf.h | 6 +++--- > src/qemu/qemu_domain.h | 1 + > src/qemu/qemu_driver.c | 6 ++++++ > src/qemu/qemu_migration.c | 39 +++++++++++++++++++++++++-------------- > 5 files changed, 38 insertions(+), 17 deletions(-) > > --- a/src/qemu/qemu_domain.h > +++ b/src/qemu/qemu_domain.h > @@ -160,6 +160,7 @@ struct _qemuDomainObjPrivate { > unsigned long migMaxBandwidth; > char *origname; > int nbdPort; /* Port used for migration with NBD */ > + int migrationPort; > > virChrdevsPtr devs; > unsigned short might be nicer here. ACK