Re: [libvirt] [PATCH] let "configure --disable-shared" work once again

Diego Elio “Flameeyes” Pettenò wrote: > Il giorno ven, 08/01/2010 alle 12.12 +0100, Jim Meyering ha scritto: >> Using -shared in python/ would now be a little misleading, >> since it's useful only when building with --disable-shared, >> and python/ is no longer built with --disable-shared. > > Not at all. It was needed to avoid building the static archive. Oh, I see what you mean, finally. I had read only the first description of -shared in libtool documentation, and hadn't realized that was only for *compile mode*. There's a slightly different description following that, in the *link mode* options section. Thanks for persevering. Here's the revised patch. >From 25dd0609205b28d8ffc2b07873b8abb75f39f2d9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <jim(a)meyering.net&gt; Date: Thu, 7 Jan 2010 21:07:42 +0100 Subject: [PATCH] let "configure --disable-shared" work once again Without this change, ./autogen.sh --disable-shared && make would evoke a "can not build a shared library" failure for libvirtmod.la due to the new use of libtool's -shared link option in python/Makefile.am. Now, --disable-shared also disables building python. * configure.in: Make --disable-shared imply --without-python and silently override --with-python. --- configure.in | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.in b/configure.in index 3f2f8ff..3e98035 100644 --- a/configure.in +++ b/configure.in @@ -1813,6 +1813,10 @@ AC_ARG_WITH([qemu-group], AC_DEFINE_UNQUOTED([QEMU_USER], ["$QEMU_USER"], [QEMU user account]) AC_DEFINE_UNQUOTED([QEMU_GROUP], ["$QEMU_GROUP"], [QEMU group account]) +if test "$enable_shared:$with_python" = no:yes; then + AC_MSG_WARN([you've used --disable-shared; so disabling python support]) + with_python=no +fi # Only COPYING.LIB is under version control, yet COPYING # is included as part of the distribution tarball.