Re: [libvirt] [PATCH v5] migration: add support for migrateURI configuration

On Tue, May 20, 2014 at 10:00:52AM +0200, Jiri Denemark wrote: > s/migrateURI/migrateHost/ in Subject. > > On Tue, May 20, 2014 at 14:08:05 +0800, Chen Fan wrote: > > For now, we set the migration URI via command line '--migrate_uri' or > > construct the URI by looking up the dest host's hostname which could be > > solved by DNS automatically. > > > > But in cases the dest host have two or more NICs to reach, we may need to > > send the migration data over a specific NIC which is different from the > > automatically resloved one for some reason like performance, security, etc. > > thus we must explicitly specify the migrateuri in command line everytime, > > but it is too troublesome if there are many such hosts(and don't forget > > virt-manager). > > > > This patch adds a configuration file option on dest host to save the > > default value set which can be specified to a migration hostname or > > one of this host's addresses used for transferring data, thus user doesn't > > boring to specify it in command line everytime. > > > > Signed-off-by: Chen Fan <chen.fan.fnst(a)cn.fujitsu.com&gt; > > --- > > > > v4-v5: using "migrate_host" instead of "migrate_uri" configuration. > > Yeah, that's the best solution which I wanted to suggest in a discussion > on v4 but I failed to actually send that email. Fortunately, Daniel > suggested the same :-) Although I'd call it "migration_host" to be > consistent with existing migration_address, migration_port_min, and > migration_port_max. ACK with Jiri's proposed additions.