Re: [Libvir] [PATCH] Show Xen vif<domid>.<n> device name in domain XML
On Mon, Aug 20, 2007 at 05:26:35PM +0100, Richard W.M. Jones wrote:
This patch changes the Xen domain XML so that it shows the target
device
(ie. vif<domid>.<n>), which you can then use to collect interface stats.
For example:
# virsh dumpxml fc6_1
...
<interface type='bridge'>
<source bridge='xenbr0'/>
<target dev='vif2.0'/>
<mac address='00:16:3e:1a:2f:8c'/>
<script path='vif-bridge'/>
</interface>
Note that this patch only adds to the XML, it doesn't change any XML
that was being returned before.
Looks fine to me. We'll also need to fix the QEMU driver too IIRC, to give
back the name of the auto-created TAP device
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|