Re: [libvirt] [PATCH 2/3] m4: Check for sanlock_write_lockspace
On 09/15/2016 10:35 AM, Michal Privoznik wrote:
Currently, we are checking for sanlock_add_lockspace_timeout
which is good for now. But in the next patches we are gonna use
s/the next patches/a subsequent patch/
s/gonna/going to/
sanlock_write_lockspace (which sets an initial value for io
timeout for sanlock). Now, there is no reason to check for both
functions in sanlock library as the sanlock_write_lockspace was
introduced in 2.7 release and the one we are currently checking
for in the 2.5 release. Therefore it is safe to assume presence
of sanlock_add_lockspace_timeout when sanlock_write_lockspace is
detected.
Moreover, the macro for conditional compilation is renamed to
HAVE_SANLOCK_IO_TIMEOUT (as it now encapsulates two functions).
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
m4/virt-sanlock.m4 | 14 +++++++++-----
src/locking/lock_driver_sanlock.c | 2 +-
2 files changed, 10 insertions(+), 6 deletions(-)
ACK (seems reasonable to me, but my m4 knowledge is light)
John