Re: [Libvir] Autostarting guests and networks

On Wed, Feb 21, 2007 at 11:54:13AM +0000, Mark McLoughlin wrote: > On Sat, 2007-02-17 at 14:12 +0800, Daniel Veillard wrote: > > > Agreed let's not mix policies and data. However I assume the API would allow > > to define directories for autostarted configs. I guess having predefined dirs for > > such data is a common concept. And trying to hard code it like /etc/xen is > > really not the best. IIRC we already have a config file now for some daemons, > > can we have such directories entries in the config file ? I guess it would give > > the flexibility required for most uses while keeping a relatively sane API and > > avoiding putting the policy in the data themselve. > > I don't think this is specific to the autostart support - i.e. we > already define /etc/libvirt/qemu as the location for qemud domain > definitions and don't have a configurable way of allowing other > directories. I think it is fine to hardcode at build time - simply allow use of a flag to configure to change the default, or let the user override the default with a flag to the libvirt_qemud process > > I've no objection to allowing multiple locations and making that > configurable, but there is a few things to bear in mind: I think allowing multiple directories is complete overkill and unnneccessarily complicates the code, as you point out below... We're not really expecting admins to manage these config files directly in any case, so I can't really see any benefit to using many dirs.