Re: [libvirt] [PATCH v2 2/4] iscsi: Add exit status checking for virISCSIGetSession

On 05/18/2016 01:55 AM, Peter Krempa wrote:

> "cannot find session iscsiadm session" followed by the message and/or > containing the code will be probably the best case here. The function > you are modifying is meant to find the session so any error is basically > that it couldn't find it. The message from iscsiadm then helps > debugging. > Fair enough... Primary thought was to be consistent with previous error, but generating/using a unique error is fine... So rather than the if then else based on exit status, how about: virReportError(VIR_ERR_INTERNAL_ERROR, _("cannot find iscsiadm session: %s"), NULLSTR(error));