Re: [libvirt] [PATCH V3 1/2] Intorduce file descriptor set for QEMU domains

On 02/07/2013 03:26 PM, Stefan Berger wrote: Perhaps my fault for first suggesting that we modify <alias> at the device_conf level, but I like the idea of tracking a hashtable at the qemu private level that maps back to <alias> as needed. Looks good to me. We may want more information on a given fdset, but that can be added later. If we need more than a alias->set number, we would instead hash an alias->struct, with XML looking something like: <fdsets> <entry alias='ide0-0-0' fdset='1'> <source>/path/to/disk.img</source> <fd id='4' mode='rdonly'/> <fd id='5' mode='rdwr'/> </entry> </fdsets> But again, without knowing whether we need extra information, your proposal is fine for now. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org