Re: [libvirt] [PATCH] Let make fail when XHTML validation fails

On Wed, Jan 20, 2010 at 02:14:43PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; > --- > docs/Makefile.am | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/docs/Makefile.am b/docs/Makefile.am > index eaac627..4df5154 100644 > --- a/docs/Makefile.am > +++ b/docs/Makefile.am > @@ -108,7 +108,7 @@ ChangeLog.html.in: ChangeLog.xml ChangeLog.xsl > @(if [ -x $(XMLLINT) -a -x $(XMLCATALOG) ] ; then \ > if $(XMLCATALOG) /etc/xml/catalog "-//W3C//DTD XHTML 1.0 Strict//EN" > /dev/null ; then \ > echo "Validating $@" ; \ > - $(XMLLINT) --nonet --format --valid $< > $@ || : ; \ > + $(XMLLINT) --nonet --format --valid $< > $@ || (rm $@ && exit 1) ; \ > else echo "missing XHTML1 DTD" ; fi ; fi ); Hum, maybe that's a bit excessive, while it make sense to see the error in a development environment, I find this a bit hard at installation time.