On Fri, Apr 10, 2015 at 14:59:05 +0200, Ján Tomko wrote:
This allows creating an external qcow2 snapshot with
qcow2 features, e.g:
<disk name='hda' snapshot='external' type='file'>
<source file='/path/to/file'/>
<compat>1.1</compat>
<features>
<lazy_refcounts/>
</features>
</disk>
https://bugzilla.redhat.com/show_bug.cgi?id=980327
---
docs/formatsnapshot.html.in | 9 +++++++
docs/schemas/domainsnapshot.rng | 10 +++++++-
src/conf/snapshot_conf.c | 12 +++++++++
.../disk_snapshot_features.xml | 30 ++++++++++++++++++++++
.../disk_snapshot_features.xml | 30 ++++++++++++++++++++++
tests/domainsnapshotxml2xmltest.c | 2 ++
6 files changed, 92 insertions(+), 1 deletion(-)
create mode 100644 tests/domainsnapshotxml2xmlin/disk_snapshot_features.xml
create mode 100644 tests/domainsnapshotxml2xmlout/disk_snapshot_features.xml
diff --git a/docs/formatsnapshot.html.in b/docs/formatsnapshot.html.in
index c3ab516..569dd24 100644
--- a/docs/formatsnapshot.html.in
+++ b/docs/formatsnapshot.html.in
@@ -180,6 +180,15 @@
as qcow2), of the new file created by the external
snapshot of the new file.
</dd>
+ <dt><code>compat</code></dt>
+ <dd>Optional. Allows specifying the compatibility level for qcow2
volumes.
+ So far, this is only used for type='qcow2' volumes. Valid values
are 0.10 and 1.1,
+ specifying QEMU version the images should be compatible with.
+ If the feature element is present, 1.1 is used. If omitted, 0.10 is used.
For this particular case I think we should drop the last sentence. If
the <compat> element is not present, regardless of the <feature> element
we should use qemu default type. If a user wants to explicitly use a
image type he should explicitly specify it.
+ <span class="since">Since
1.2.15</span></dd>
+ <dt><code>features</code></dt>
+ <dd>Format-specific features. See the features element in
+ <a href="formatstorage.html">volume target
elements</a> for valid features</dd>
</dl>
<span class="since">Since 1.2.2</span> the
<code>disk</code> element
Peter