Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor
于 2011年08月16日 00:27, Adam Litke 写道:
On 08/15/2011 08:23 AM, Osier Yang wrote:
> 于 2011年08月15日 21:58, Osier Yang 写道:
>> * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as
>> "balloon: actual=", which cause "actual=" is stripped early
before
>> the real parsing. This patch changes BALLOON_PREFIX into "balloon: ",
>> and modifies related functions, also renames
>> "qemuMonitorParseExtraBalloonInfo" to
"qemuMonitorParseBalloonInfo",
>> as after the changing, it parses all the info returned by "info
balloon".
> Forgot to mention the problem, e.g. "virsh dommemstat $domain" returns
empty
> result.
That is because qemu has disabled stats reporting and so the extra
fields are not present in the info balloon response.
Yes, I made a patch for this before (commit 41514f7b), but I didn't
realize the "actual="
is stripped early before the parsing, so with the commit, one will get
value of "actual"
at least in QMP mode even the extra fields are disabled by qemu. But for
text monitor,
the problem still exists, this patch is to fix it.
Osier