Re: [libvirt] [PATCH 7/6] virtio-rng: Add rate limiting options for virtio-RNG
On 02/19/2013 08:39 AM, Peter Krempa wrote:
On 02/19/13 14:21, John Ferlan wrote:
> On 02/13/2013 11:28 AM, Peter Krempa wrote:
>
> bits or bytes?
>
qemu uses bits for it's configuration value. As the expected data rades
are pretty low, I think bits can be used and potentially divided to
larger values if needed.
Peter
OK - when I scrolled down to the changes in qemu_command.c/
qemuBuildRNGDeviceArgs(), I saw:
+ if (dev->rate > 0) {
+ virBufferAsprintf(&buf, ",max-bytes=%u", dev->rate);
+ if (dev->period)
+ virBufferAsprintf(&buf, ",period=%u", dev->period);
+ else
+ virBufferAddLit(&buf, ",period=1000");
+ }
+
Hence the reason I asked...
John