Re: [libvirt] [PATCH 3/5] virstring: Introduce virVasprintfNOOM and make virVasprintf report OOM

On 04/02/2013 08:22 AM, Michal Privoznik wrote: > --- > src/libvirt_private.syms | 1 + > src/qemu/qemu_domain.c | 4 +--- > src/util/viraudit.c | 2 +- > src/util/vircommand.c | 4 ++-- > src/util/virerror.c | 2 +- > src/util/virlog.c | 2 +- > src/util/virstring.c | 22 ++++++++++++++++++++-- > src/util/virstring.h | 3 +++ > 8 files changed, 30 insertions(+), 10 deletions(-) > > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms > index 5060b87..8d1abe7 100644 > --- a/src/libvirt_private.syms > +++ b/src/libvirt_private.syms > @@ -1742,6 +1742,7 @@ virStrToLong_ul; > virStrToLong_ull; > virTrimSpaces; > virVasprintf; > +virVasprintfNOOM; Bike-shedding: Maybe virVasprintfQuiet works better? I'm a bit worried that the NOOM suffix will cause more questions than it resolves about what it is really doing, which is being silent on OOM conditions.