Re: [PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest
On 11/3/23 6:11 AM, Andrea Bolognani wrote:
On Fri, Nov 03, 2023 at 12:00:30AM -0400, Laine Stump wrote:
> [*] There may be a better way to suppress this environment setting
> (maybe something done to prevent it from ever being added to the
> environment in the first place?), and that would be fine too. This
> patch does work though.
Yeah, I think this is pretty safe but it's kinda weird that this
specific environment variable would make it through despite our
filtering mechanisms in virCommand. So if some good soul with access
to a macOS 14 installation (*cough cough* ;) could try to figure out
why this started showing up all of a sudden, when it was not there
for any previous version of macOS, that would be absolutely awesome.
Well, I have access to macos 14, but not to anything earlier. It seems
pretty cut/dried that our virCommand gives the child process a very
limited environment, so it Dan's supposition must be correct. Possibly
it can be eliminated by setting the C locale or something?