Re: [Libvir] [PATCH] setmem checks
On Fri, Jun 15, 2007 at 12:31:41PM -0400, Mark Johnson wrote:
On 6/15/07, Daniel P. Berrange <berrange(a)redhat.com> wrote:
>On Fri, Jun 15, 2007 at 11:30:02AM -0400, Mark Johnson wrote:
>> Which of these does folks prefer (same would apply to SetMaxMem).
>
>I prefer the first. Full error checking & reporting. GetInfo should
>never fail under any reasonable scenario. If it does fail its very
>unlikely that a SetMemory would then work, so its pointless continuing
>
update patch attached.
Cool, applied !
thanks a lot !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/