Re: [PATCH 0/2 for 8.0] Update index after allocating port for isa-serial device
On 13/01/22 8:13 pm, Michal Prívozník wrote:
On 1/13/22 08:33, Divya Garg wrote:
> Issue
> Divya Garg (2):
> Add the port allocation logic for isa-serial devices.
> qemu: add index for isa-serial device using target.port
> 61 files changed, 156 insertions(+), 90 deletions(-)
>
Hey, couple of points. Usually, when sending new version we do so in a
new thread. And we don't CC random people. Us, developers, are
subscribed to the list.
Hi Michal ! Actually I was told to CC all those who
commented on the patch
atleast once ! Hence added them in CC. But in future I will take care of
this.
Thankyou !!
Anyway, I'm raising only very basic nitpicks with your patches. I'll
squash in the fixes I'm suggesting before pushing. Speaking of which, we
are currently in freeze, preparing for tomorrow's release. so I'll push
these tomorrow.
Thankyou so much !!
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal