Re: [libvirt] [RFC PATCH 0/5] another <disk> refactoring
On Wed, May 21, 2014 at 22:50:43 -0600, Eric Blake wrote:
I'm about to reuse the <mirror> sub-element of <disk>
for my
pending series on active block commit, but to do that, I
wanted to get some refactoring out of the way first. Patches
1-4 are pretty straightforward, and 5 may be controversial
(I'm sending it now, even though it still needs more work, to
make sure I'm not doing something bad). I'm aware that this
will probably cause some rebase pain for Peter's work with
gluster, but at the same time, it will ease some of the work
that Benoit wants for introducing quorums.
I think we all agree that we need to do this refactoring. However, the
timing is not very good given that Peter already has lots of patches
mostly ready to be submitted to the list while Benoit's work on quorums
is only in its XML design phase. In other words, we should first wait
for Peter's patches and Benoit may in the mean time work on his patches
which will count with your refactoring. But pushing this refactoring now
is not going to help anyone.
In other words, NACK to patches 1-3 until patches for gluster snapshots
and relative backing chains land in.
Jirka