Re: [libvirt] python module set-up ignores virInitialize failure

On Tue, May 18, 2010 at 12:32:13PM +0200, Jim Meyering wrote: > I've just fixed code in a test that ignored virInitialize failure. > Looking at all uses, I saw one other: in python/libvirt-override.c, > where the initialization function ignores virInitialize failure: > > void > #ifndef __CYGWIN__ > initlibvirtmod > #else > initcygvirtmod > #endif > (void) > { > static int initialized = 0; > > if (initialized != 0) > return; > > virInitialize(); > > /* initialize the python extension module */ > Py_InitModule((char *) > #ifndef __CYGWIN__ > "libvirtmod" > #else > "cygvirtmod" > #endif > , libvirtMethods); > > initialized = 1; > } > > Unfortunately, this function is public, so we can't change its signature. More specifically, the signature is defined by Python's loadable module interface so we're not at liberty to redeclare that. > Any suggestions? abort()