Re: [libvirt] [RFC PATCH 5/6] conf: Parse and format HPT maxpagesize
On Wed, May 23, 2018 at 18:52:57 +0200, Andrea Bolognani wrote:
On Wed, 2018-05-23 at 18:36 +0200, Peter Krempa wrote:
> On Wed, May 23, 2018 at 18:18:01 +0200, Andrea Bolognani wrote:
> > + def->hpt_maxpagesize = VIR_ROUND_UP(def->hpt_maxpagesize,
1024);
>
> The code in the patch using it with qemu actually expects so this is a
> power of 2, so you'll need a different rounding function.
Good point!
Looks like VIR_ROUND_UP_POWER_OF_TWO() will do the trick.
Yes. We usually do the rounding in the code which prepares the
definition for the startup of the VM though, so that other hypervisor
drivers don't need to share the limits of qemu.
Given that this is a ppc64 specific option it probably does not matter
much.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)