Re: [libvirt] [PATCHv2 15/15] virsh: improve memory unit parsing
On 03/07/2012 06:14 AM, Peter Krempa wrote:
On 03/06/2012 01:34 AM, Eric Blake wrote:
> The last vestige of the inaccurate 'kilobytes' when we meant 1024 is
> now gone. And virsh is now useful for setting memory in units other
> than KiB.
>
>
> +static int
> +cmdMemtuneGetSize(const vshCmd *cmd, const char *name, long long *value)
As this is a helper function rename it please to vshMemtuneGetSize to
avoid confusion with command functions.
Sure.
ACK with the name change.
Thanks for the review. Nits fixed, and series pushed.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)