Re: [libvirt] [PATCH 3/3] qemu: support configuring usb3 controller port count

On 04/27/2016 02:29 PM, Cole Robinson wrote: > This adds a ports= attribute to usb controller XML, like > > <controller type='usb' model='nec-xhci' ports='8'/> > > This maps to: > > qemu -device nec-usb-xhci,p2=8,p3=8 > > Meaning, 8 ports that support both usb2 and usb3 devices. Gerd > suggested to just expose them as one knob. > > https://bugzilla.redhat.com/show_bug.cgi?id=1271408 > --- > docs/formatdomain.html.in | 6 ++-- > docs/schemas/domaincommon.rng | 8 ++++- > src/conf/domain_conf.c | 39 ++++++++++++++-------- > src/conf/domain_conf.h | 7 ++++ > src/qemu/qemu_command.c | 13 ++++++++ > .../qemuxml2argv-usb-controller-xhci.args | 22 ++++++++++++ > .../qemuxml2argv-usb-controller-xhci.xml | 16 +++++++++ > tests/qemuxml2argvtest.c | 3 ++ > 8 files changed, 98 insertions(+), 16 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-xhci.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-xhci.xml > Do you need any virDomainControllerDefCheckABIStability checks with these changes? w/r/t ports value Other than that things looked fine to me (couldn't run through normal building process because I didn't want to deal with patch2 merges). ACK - I trust you'll make the right check if you need it.