Re: [libvirt] [PATCH 05/10] conf: Introduce new attribute for device address format
On 2012年02月18日 00:41, Paolo Bonzini wrote:
On 02/17/2012 06:18 PM, Osier Yang wrote:
> + if ((bus == VIR_DOMAIN_DISK_BUS_SCSI)&&
> + (controllerModel != VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LSILOGIC)) {
> + virBufferAsprintf(buf, " controller='%d' bus='%d'
target='%d' unit='%d'",
> + info->addr.drive.controller,
> + info->addr.drive.bus,
> + info->addr.drive.target,
> + info->addr.drive.unit);
> + } else {
> + virBufferAsprintf(buf, " controller='%d' bus='%d'
unit='%d'",
> + info->addr.drive.controller,
> + info->addr.drive.bus,
> + info->addr.drive.unit);
> + }
Yeah, I definitely misunderstood. Here it is correct to print the
target for all models.
Do you mean it's correct check the model here? I think the "lsilogic"
model won't want to see the "target". It's complete useless.
Osier