Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project
On Fri, Apr 13, 2018 at 03:24:09PM +0200, Andrea Bolognani wrote:
On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> diff --git a/guests/vars/projects/virt-viewer.yml
b/guests/vars/projects/virt-viewer.yml
> index 6f3dbf9..85d1589 100644
> --- a/guests/vars/projects/virt-viewer.yml
> +++ b/guests/vars/projects/virt-viewer.yml
> @@ -6,5 +6,29 @@ packages:
> - intltool
> - libgovirt
> - libxml2
> + - mingw32-adwaita-icon-theme
> + - mingw32-glib2
Forgot to mention: mingw*-glib2 is not necessary here based on our
discussion, as it's already required to build libvirt-glib :)
This falls into similar case as mingw-spice-glib you point out though.
eg If it is directly used by virt-viewer, it is reasonable to include
it. We just want drop the things which are indirect dependancies. eg
mingw-gnutls as gnutls is used only by libvirt, not directly by
virt-viewer/libvirt-glib so doesn't need listing separately.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|