Re: [libvirt-ci PATCH 2/2] Build libvirt-tck on CentOS 8
On Mon, 2020-04-20 at 17:58 +0100, Daniel P. Berrangé wrote:
On Mon, Apr 20, 2020 at 06:52:59PM +0200, Andrea Bolognani wrote:
> Now the question is: if these are actual build requirements, how can
> the build succeed and the test suite pass?
Well the "build" phase in Perl essentially does nothing more than copying
files from one dir to another dir, so that won't care. The test suite will
need more stuff, but the test suite is fairly minimal in what it does, so
I'm not entirely surprised it passes.
I'm 100% confident if you actually run the TCK though it will fail due to
these missing pieces, most critically the Config::Record module.
I'd probably just leave it disabled on both CentOS but with fixed comments
to say why
Sounds good to me.
Can you ACK the first patch in the series? That one is connected only
by the fact that it also touches CentOS, and it doesn't make a lot of
sense to send it again when I respin this one.
--
Andrea Bolognani / Red Hat / Virtualization