Re: [libvirt] [for 1.2.6] Redundancy of virNetworkGetDHCPLeases and virNetworkGetDHCPLeasesForMAC

>> Both of those return a list of lease structures and the only difference >> is the presence of the @mac argument. >> >> We could unify those two APIs into one with the following signature: >> >> int >> virNetworkGetDHCPLeases(virNetworkPtr network, >> const char *mac, >> virNetworkDHCPLeasePtr **leases, >> unsigned int flags) >> >> And tweak the semantics of @mac where when the user passes NULL we'd >> return the complete unfiltered list.

Of course what I completely missed was that even in the ForMAC case, we have to return a dynamic list of leases, because you can have both IPv4 and IPv6 leases for the same MAC. This basically kills the main compelling reason to have 2 separate APIs.

So in retrospect I was wrong, and I agree with Peter that we should kill the ForMAC API and just add an (optional) macaddr parameter to the first API. Of course we can only decided to do this now before we release.