Re: [libvirt PATCH v5 30/32] qemu: implement knownHosts for ssh disks with nbdkit
On Thu, Feb 16, 2023 at 17:50:50 +0100, Peter Krempa wrote:
On Tue, Feb 14, 2023 at 11:08:17 -0600, Jonathon Jongsma wrote:
> For ssh disks that are served by nbdkit, use the configured value for
> knownHosts and pass it to the nbdkit process.
>
> Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com>
> ---
> src/conf/domain_conf.c | 8 ++++++++
> src/conf/storage_source_conf.c | 1 +
> src/conf/storage_source_conf.h | 2 ++
> src/qemu/qemu_nbdkit.c | 3 +++
> tests/qemunbdkitdata/disk-network-ssh-password.args.disk0 | 3 ++-
> tests/qemunbdkitdata/disk-network-ssh.args.disk0 | 3 ++-
> tests/qemuxml2argvdata/disk-network-ssh-password.xml | 1 +
> tests/qemuxml2argvdata/disk-network-ssh.xml | 1 +
> 8 files changed, 20 insertions(+), 2 deletions(-)
One additional node. Selinux may not allow access to the file for nbdkit
based on the policy. We might need to do security labelling on the file
if that is the case.