Re: [libvirt] [RFC/PATCH python] expose the bindings version to Python

On 12/11/2013 08:43 PM, Doug Goldstein wrote: > The method getVersion() retrieves the version of the libvirt library > that the binaries are linked against but there is no way to retrieve the > version of the bindings you are using. In the future if we support new > APIs in Python that don't rely on features in the library there needs to > be a way for programmers to detect the version. > --- > I would expect there's a cleaner way to implement this than I've done > but I opted for what I saw as the smallest implementation. If anyone > has a suggestion for a better way to do this I'm ok with redoing this > patch. The idea sounds sane to me. > --- > libvirt-override.py | 3 +++ > setup.py | 16 ++++++++++++++++ > 2 files changed, 19 insertions(+) Alas, my python is too weak to give either a meaningful review to the code, or to suggest an alternative. :( -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org