Re: [libvirt] [PATCH v3 3/9] all: Use virFileCanonicalizePath() instead of canonicalize_file_name()
On Thu, May 03, 2018 at 12:54:17PM +0200, Andrea Bolognani wrote:
The latter is impossible to mock on platforms that use the
gnulib implementation, such as FreeBSD, while the former
doesn't suffer from this limitation.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
src/storage/storage_backend_fs.c | 2 +-
src/util/virfile.c | 2 +-
src/util/virpci.c | 2 +-
tests/virstoragetest.c | 10 +++++-----
tests/virtestmock.c | 6 +++---
5 files changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|